-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: Removes routerHistory
from Redux store
#573
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #573 +/- ##
======================================
Coverage 9.17% 9.18%
======================================
Files 113 113
Lines 5273 5270 -3
Branches 703 703
======================================
Hits 484 484
+ Misses 4121 4119 -2
+ Partials 668 667 -1 ☔ View full report in Codecov by Sentry. |
The next version of Redux throws an error by default whenever there are non-serializable objects in its Store ( more about this on this article ). This PR is one in a series of PRs that aim to refactor all of those instances before the upgrade.
The
routerHistory
property stored is currently used for navigating inside our Sagas. The proposed solution is to:navigateTo
property on the storeuseEffect()
inside theApp.js
screen listening to changes on this propertyApp.js
becomes responsible for navigating whenever a background task requests it toAcceptance Criteria
routerHistory
should not be present on the Redux StoreSecurity Checklist