Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrades react-router to v6 #555

Merged
merged 13 commits into from
Mar 28, 2024
Merged

chore: Upgrades react-router to v6 #555

merged 13 commits into from
Mar 28, 2024

Conversation

tuliomir
Copy link
Collaborator

@tuliomir tuliomir commented Mar 22, 2024

This PR upgrades the React Router from version 5.x to v6. Below are the guides followed to implement the necessary adaptations:

Acceptance Criteria

  • Upgrades the React Router to the latest stable version v6

Notes

  • It's still not recommended to store the full navigation object to use on Sagas (link), but changing this approach on our code is beyond the scope of this PR ( additional reading )
  • Most of the file changes were due to renaming all instances of useHistory to useNavigate on the screens. These changes are concentrated on the c99a74f commit for easier reviewing

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@tuliomir tuliomir added the dependencies Pull requests that update a dependency file label Mar 22, 2024
@tuliomir tuliomir self-assigned this Mar 22, 2024
@tuliomir tuliomir mentioned this pull request Mar 22, 2024
1 task
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 98 lines in your changes are missing coverage. Please review.

Project coverage is 9.17%. Comparing base (abb4da2) to head (c7c8dd9).

Files Patch % Lines
src/App.js 0.00% 19 Missing ⚠️
src/sagas/wallet.js 0.00% 7 Missing ⚠️
src/components/TokenBar.js 0.00% 4 Missing ⚠️
src/screens/LockedWallet.js 0.00% 4 Missing ⚠️
src/screens/Settings.js 0.00% 4 Missing ⚠️
src/screens/Signin.js 0.00% 4 Missing ⚠️
src/screens/atomic-swap/ProposalList.js 0.00% 4 Missing ⚠️
src/screens/ChoosePassphrase.js 0.00% 3 Missing ⚠️
src/screens/CustomTokens.js 0.00% 3 Missing ⚠️
src/screens/LoadWallet.js 0.00% 3 Missing ⚠️
... and 21 more
Additional details and impacted files
@@            Coverage Diff            @@
##           master    #555      +/-   ##
=========================================
- Coverage    9.18%   9.17%   -0.01%     
=========================================
  Files         113     113              
  Lines        5269    5273       +4     
  Branches      703     703              
=========================================
  Hits          484     484              
- Misses       4117    4121       +4     
  Partials      668     668              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tuliomir tuliomir requested review from andreabadesso and r4mmer and removed request for pedroferreira1 March 22, 2024 22:57
src/components/RequestError.js Outdated Show resolved Hide resolved
src/screens/NewWallet.js Outdated Show resolved Hide resolved
src/ErrorWrapper.js Show resolved Hide resolved
src/components/BackButton.js Show resolved Hide resolved
src/screens/NewWallet.js Show resolved Hide resolved
@tuliomir tuliomir merged commit 7c2f02a into master Mar 28, 2024
3 checks passed
@tuliomir tuliomir deleted the chore/router-v6 branch March 28, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants