-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Upgrades react-router
to v6
#555
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #555 +/- ##
=========================================
- Coverage 9.18% 9.17% -0.01%
=========================================
Files 113 113
Lines 5269 5273 +4
Branches 703 703
=========================================
Hits 484 484
- Misses 4117 4121 +4
Partials 668 668 ☔ View full report in Codecov by Sentry. |
tuliomir
commented
Mar 22, 2024
tuliomir
requested review from
andreabadesso and
r4mmer
and removed request for
pedroferreira1
March 22, 2024 22:57
r4mmer
reviewed
Mar 26, 2024
tuliomir
force-pushed
the
chore/router-v6
branch
from
March 26, 2024 17:13
d141a24
to
0d08da8
Compare
r4mmer
approved these changes
Mar 26, 2024
# Conflicts: # src/App.js
tuliomir
force-pushed
the
chore/router-v6
branch
from
March 28, 2024 13:50
fbf87d4
to
c7c8dd9
Compare
andreabadesso
approved these changes
Mar 28, 2024
1 task
This was referenced Apr 29, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades the React Router from version
5.x
tov6
. Below are the guides followed to implement the necessary adaptations:Root
screen to functional component #502 )Acceptance Criteria
Notes
useHistory
touseNavigate
on the screens. These changes are concentrated on the c99a74f commit for easier reviewingSecurity Checklist