chore: wallet-service monorepo [part 2] - CI #99

andreabadesso · 2023-11-30T16:05:57Z

Acceptance Criteria

We should run tests for the wallet-service lambdas on every push
We should run tests for the daemon on every push
We should update the aws-sdk to v3 as v2 was deprecated
We should update jest to the latest version

Security Checklist

Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

…efore processing it

…dability

… root project

andreabadesso · 2023-12-06T15:48:27Z

packages/daemon/__tests__/db/index.test.ts

@@ -843,7 +843,7 @@ describe('address and wallet related tests', () => {
    for (const [index, address] of addressesInfo.addresses.entries()) {
      expect(ADDRESSES[index]).toBe(address);
    }
-  } );
+  }, 15000);


It times out with less than 15s

andreabadesso · 2023-12-06T15:49:07Z

packages/daemon/__tests__/services/services.test.ts

-
-  it('transaction already in the database should throw', async () => {
-    const context = {
-      event: {
-        event: {
-          data: {
-            hash: 'hashValue',
-          },
-          id: 'idValue',
-        },
-      },
-    };
-
-    const mockTransaction = { tx_id: 'hashValue' };
-    (getTransactionById as jest.Mock).mockResolvedValue(mockTransaction);
-
-    await expect(handleVertexAccepted(context as any, {} as any)).rejects.toThrow('Transaction hashValue already in the database, this should never happen');
-  });


This condition was removed on the reliable-integrations part 2 PR, this test was failing

andreabadesso · 2023-12-06T15:49:27Z

packages/daemon/package.json

@@ -35,7 +35,7 @@
    "typescript": "^4.9.5"
  },
  "dependencies": {
-    "@hathor/wallet-lib": "^1.0.2",
+    "@hathor/wallet-lib": "^0.39.0",


We should update the wallet-lib on another PR for both the daemon and the wallet-service

andreabadesso · 2023-12-06T15:50:38Z

packages/wallet-service/src/utils.ts

@@ -7,6 +7,7 @@

 import { BinaryToTextEncoding, createHash } from 'crypto';

+import { Logger } from 'winston';


Not sure why this happened, but the build was failing because of this missing dependency

I believe its used as an argument type, maybe the LSP does not count type annotations as usage of the import.

andreabadesso · 2023-12-06T15:52:30Z

packages/wallet-service/tests/utils.ts

+bitcore.Networks.add({
+  ...network.bitcoreNetwork,
+  networkMagic: network.bitcoreNetwork.networkMagic.readUInt32BE(),
+});
+
+export const getXPrivKeyFromSeed = (
+  seed: string,
+  options: {
+    passphrase?: string,
+    networkName?: string
+  } = {}): bitcore.HDPrivateKey => {
+  const methodOptions = Object.assign({passphrase: '', networkName: 'mainnet'}, options);
+  const { passphrase, networkName } = methodOptions;
+
+  const network = new Network(networkName);
+  const code = new Mnemonic(seed);
+  return code.toHDPrivateKey(passphrase, network.bitcoreNetwork);
+};


I had to create my own getXPrivKeyFromSeed because the lib was having issues with its own bitcore-mnemonic dependency

I also had to add Hathor's network manually to be able to use the wallet-lib methods

andreabadesso · 2023-12-06T15:55:44Z

packages/wallet-service/tests/api.test.ts

@@ -181,7 +182,7 @@ test('GET /addresses', async () => {
  expect(result.statusCode).toBe(STATUS_CODE_TABLE[ApiError.INVALID_PAYLOAD]);
  expect(returnBody.details).toHaveLength(1);
  expect(returnBody.details[0].message)
-    .toMatchInlineSnapshot('"\\"index\\" must be greater than or equal to 0"');
+    .toMatchInlineSnapshot('"\"index\" must be greater than or equal to 0"');


Had to update all inline snapshots after jest update

r4mmer · 2023-12-07T16:23:36Z

packages/wallet-service/src/utils.ts

@@ -7,6 +7,7 @@

 import { BinaryToTextEncoding, createHash } from 'crypto';

+import { Logger } from 'winston';


I believe its used as an argument type, maybe the LSP does not count type annotations as usage of the import.

andreabadesso added 30 commits November 30, 2023 11:53

chore: removed old service files

0f07747

chore: added package changes

7857de3

chore: initial project structure

c9cb7f4

feat: added sync machine to the project with mocked services

2e9e7da

feat: added services

eb776d9

feat: added services, utils and types

abe3b85

feat: added websocket actor

958c035

feat: added LRU cache and md5hash

949020a

chore: basic eslintrc

ab8d177

fix: added voided guard to check if a transaction is already voided b…

db99604

…efore processing it

tests: added multiple tests for db methods

073084e

chore: added database migrations

9182510

chore: removed tests from tslint and added sequelize to dependencies

75fad03

refactor: moved guards and actions to separate files and improved rea…

c3fb747

…dability

tests: 100% coverage on guards

e08f964

chore: added sequelizerc

e088a09

feat: throw if storing event lower than current

ba709ec

chore: removed seeders as they're no longer needed

6c771d3

chore: added daemon to a workspace

7f3b878

chore: moved tsconfig to daemon workspace

7cd0c6e

chore: removed db models as they were never used and is irrelevant on…

644507e

… root project

chore: added github test action using nix

432f1ca

chore: added CI to pull_request as well

2c4433c

chore: removed fixed url for nix installation

59a6010

chore: moved remaining files

5d8952f

chore: added wallet-service as a package

e15f76f

chore: added dependencies to run migration from root project

13381bb

chore: removed .serverless from git

4bef8b3

chore: updated github workflow to setup the environment

05fb1ed

chore: updated daemon package with reliable-integrations

9a3f629

andreabadesso force-pushed the chore/monorepo-pt2 branch 3 times, most recently from 73eb29d to 215ef98 Compare December 5, 2023 22:28

andreabadesso requested review from glevco and r4mmer December 6, 2023 15:31

andreabadesso force-pushed the chore/monorepo-pt2 branch from 215ef98 to 40d8510 Compare December 6, 2023 15:33

tests: fix bitcore-lib tests

9864bc7

andreabadesso force-pushed the chore/monorepo-pt2 branch from 40d8510 to 9864bc7 Compare December 6, 2023 15:35

andreabadesso changed the title ~~chore: wallet-service monorepo [part 2] - CI + CD~~ chore: wallet-service monorepo [part 2] - CI Dec 6, 2023

chore: updated yarn lock

3596aab

andreabadesso commented Dec 6, 2023

View reviewed changes

r4mmer approved these changes Dec 7, 2023

View reviewed changes

empty commit

b8863bb

glevco approved these changes Dec 8, 2023

View reviewed changes

Base automatically changed from chore/monorepo to dev December 11, 2023 14:35

andreabadesso force-pushed the chore/monorepo-pt2 branch 4 times, most recently from b680990 to b8863bb Compare December 11, 2023 15:24

Merge branch 'dev' into chore/monorepo-pt2

86f3106

andreabadesso merged commit 5b7d6bc into dev Dec 11, 2023
1 check passed

andreabadesso deleted the chore/monorepo-pt2 branch February 22, 2024 15:11

This was referenced Feb 23, 2024

Release-candidate 1.4.5-rc.1+beta #133

Closed

Release-candidate 1.4.5-rc.1+beta #134

Merged

Release v1.4.6 #136

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: wallet-service monorepo [part 2] - CI #99

chore: wallet-service monorepo [part 2] - CI #99

andreabadesso commented Nov 30, 2023 •

edited

Loading

andreabadesso Dec 6, 2023

andreabadesso Dec 6, 2023

andreabadesso Dec 6, 2023

andreabadesso Dec 6, 2023

r4mmer Dec 7, 2023

andreabadesso Dec 6, 2023

andreabadesso Dec 6, 2023

r4mmer Dec 7, 2023

		@@ -7,6 +7,7 @@

		import { BinaryToTextEncoding, createHash } from 'crypto';

		import { Logger } from 'winston';

chore: wallet-service monorepo [part 2] - CI #99

chore: wallet-service monorepo [part 2] - CI #99

Conversation

andreabadesso commented Nov 30, 2023 • edited Loading

Acceptance Criteria

Security Checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

andreabadesso commented Nov 30, 2023 •

edited

Loading