Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better document package building decisions #172

Open
2 tasks
andreabadesso opened this issue Jun 12, 2024 · 0 comments
Open
2 tasks

Better document package building decisions #172

andreabadesso opened this issue Jun 12, 2024 · 0 comments

Comments

@andreabadesso
Copy link
Collaborator

andreabadesso commented Jun 12, 2024

          question(non-blocking): Should we add these instructions to a document on the repository itself?

          There seem to be many of those small details that can break the production environment and delay future maintenance releases if left unchecked.

Originally posted by @tuliomir in #170 (comment)

We should create a document describing the details needed for this project to build, like:

  • wallet-lib must be a peerDependency to prevent bitcore-lib from failing because of multiple instances of it.
  • tsconfig from the common module is being built during the build process of the packages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant