Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mislabeling of weapon skills #130

Open
Linkaaaaa opened this issue Jul 5, 2024 · 1 comment
Open

Mislabeling of weapon skills #130

Linkaaaaa opened this issue Jul 5, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@Linkaaaaa
Copy link
Contributor

Examples of Dagger 3 and Greatsword 5 on a Harbinger page

7644
7645

Greatsword 5 is labeled correctly on a Reaper page but Dagger 3 does not.

7646

Dagger 3 is not labeled correctly even on Core Necromancer

7647

May or may not be related to #126

Code to review, may be caused by the specialization check, breaking with weapon mastery, it doesn't explain the mislabeling of dagger though. https://github.com/HardstuckGuild/GW2-Tooltips.js/blob/master/src/TooltipsV2.ts#L899

@Linkaaaaa Linkaaaaa added the bug Something isn't working label Jul 5, 2024
@Linkaaaaa
Copy link
Contributor Author

Linkaaaaa commented Jul 8, 2024

While looking into a better labeling logic, dual skills should be looked into too.

A dual skill should display [Main set] / [Off set] [number 3] for Thief and Weaver, don't remember if there are other classes that work like that.

Examples:

This should be (Dagger + Pistol 3)
7667

(Dagger + Dagger 3)
7668

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant