Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sound Banks Should Allow More Than 3 Samples Per Instrument #478

Open
gheskett opened this issue Aug 9, 2022 · 0 comments
Open

Sound Banks Should Allow More Than 3 Samples Per Instrument #478

gheskett opened this issue Aug 9, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request low priority Non-urgent issue or feature / low priority monkaS monkaS
Milestone

Comments

@gheskett
Copy link
Collaborator

gheskett commented Aug 9, 2022

This could be useful because:

  • Some instruments (e.g. piano) sound terrible split into just 3 samples, making their use a headache while potentially sacrificing MIDI channel space and additional instrument data
  • Eventual sf2->sm64 converter would be much more practical

This is not a small change; both the conversion tools and a decent portion of the audio code would need modified for this to work. As long as the 3 instrument cap isn't partially imposed by libultra, this should be possible. Performance could technically be made worse with this if implemented poorly but probably not by much.

@gheskett gheskett added enhancement New feature or request low priority Non-urgent issue or feature / low priority monkaS monkaS labels Aug 9, 2022
@gheskett gheskett added this to the 2.2 milestone Aug 9, 2022
@gheskett gheskett self-assigned this Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request low priority Non-urgent issue or feature / low priority monkaS monkaS
Projects
Status: To do
Development

No branches or pull requests

1 participant