Call to /user/revive doesn't check if the user is really dead.

[MagicMicky]

I think there's been an ommission when implementing the /user/revive API call as discussed in #3056.
The problem is that when you call /user/revive, you indeed reset the gold to 0, the health to 50 and remove an item, without checking if the user is really dead.
It could end up in bad implementation where you might call the /user/revive API without the user actually being dead.

My opinion would be that it should send back an error if the user isn't dead, or do as it does if the user is indeed dead.

Cheers,

[MagicMicky]

Did someone check if it was true ?

[paglias]

@MagicMicky you were right, fixing it, see https://github.com/HabitRPG/habitrpg-shared/blob/1e441d6fcd4fe5f512a2435d6f0929d5fdf5f4d2/script/index.coffee#L386

[paglias]

typo fixed in HabitRPG/habitrpg-shared@e788872

[MagicMicky]

Thanks a lot ! :)