Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Security: return the same error for wrong username/password #2423

Closed
colegleason opened this issue Jan 16, 2014 · 1 comment
Closed

Security: return the same error for wrong username/password #2423

colegleason opened this issue Jan 16, 2014 · 1 comment

Comments

@colegleason
Copy link
Contributor

We currently return two different modals for a wrong username or a wrong password. This is a security hole as it allows people to farm usernames for login. If you can do this it's easy to compare with leaked/hacked DBs from other sites and try the same password.

screen shot 2014-01-16 at 12 17 06 am
screen shot 2014-01-16 at 12 16 52 am
@colegleason
Copy link
Contributor Author

Additionally, I worry about timing attacks, but I have no evidence that Habit is susceptible yet.

@lorian lorian mentioned this issue Feb 8, 2014
Merged
@deilann deilann closed this as completed Feb 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@colegleason @deilann