Healthy check issue?

[hsyrjaos]

Issue description

Healthy check compared to wrong field -> not working.
Here is the possible fix:
diff --git a/habanalabs.go b/habanalabs.go
index 8a545c6..000f6a5 100644
--- a/habanalabs.go
+++ b/habanalabs.go
@@ -158,8 +158,8 @@ func watchXIDs(ctx context.Context, devs []*pluginapi.Device, xids chan<- *plugi
continue
}

•                   serial, err := dev.SerialNumber() // BUG: fix this was before UUID
  

•                   if err != nil || len(serial) == 0 {
  

•                   uuid, err := dev.UUID()
  

•                   if err != nil || len(uuid) == 0 {
                            slog.Error("XidCriticalError: All devices will go unhealthy", "xid", e.Etype)
                            // All devices are unhealthy
                            for _, d := range devs {
  

@@ -169,7 +169,7 @@ func watchXIDs(ctx context.Context, devs []*pluginapi.Device, xids chan<- *plugi
}

                    for _, d := range devs {

•                           if d.ID == serial {
  

•                           if d.ID == uuid {
                                    slog.Error("XidCriticalError: the device will go unhealthy", "xid", e.Etype, "aip", d.ID)
                                    xids <- d
                            }
  

Steps to reproduce (describe as minimally and precisely as possible)?

unhealthy condition never match.

OS

Linux 6.11.10-061110-generic x86_64 PRETTY_NAME="Ubuntu 22.04.5 LTS" NAME="Ubuntu" VERSION_ID="22.04" VERSION="22.04.5 LTS (Jammy Jellyfish)" VERSION_CODENAME=jammy ID=ubuntu ID_LIKE=debian HOME_URL="https://www.ubuntu.com/" SUPPORT_URL="https://help.ubuntu.com/" BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/" PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy" UBUNTU_CODENAME=jammy

Kernel Version

6.11.10-061110-generic

Container Runtime Type/Version

any

K8s Flavor/Version(e.g. K8s, OCP, Rancher, GKE, EKS)

all

Extra logs and files

No response