Fixed bugs, made POSIX compliant, clearer messages #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This accounts for the complete truth table of (is var set?) and (are we on JSC?). If neither is the case, the scripts aborts. Furthermore, the abort message format is made consistent with another abort location (where I did not add a suggestion as providing model component parameters is already in the README). Finally, I made messages for "things about to be done" contrast to aborts by making them present continuous tense and adding an ellipsis.
kvrigor
requested changes
Dec 6, 2024
This does not work on OpenBSD.
mvhulten
changed the title
Now we're sure realpath(1) gets an argument (not an empty string).
mvhulten
force-pushed
the
fix-mvh-aborts
branch
from
9010dc1 to
e998af6
Compare
kvrigor
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This accounts for the complete truth table of (is var set?) and (are we on JSC?). If neither is the case, the scripts aborts.Furthermore, the abort message format is made consistent with another abort location (where I did not add a suggestion as providing model component parameters is already in the README).Fixed bug, made mkdir usage POSIX-compliant.
Further, I made messages for "things about to be done" contrast to aborts by making them present continuous tense and adding an ellipsis.