Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add v2.0 endpoint support #39

Open
DimaGershman opened this issue Feb 15, 2018 · 0 comments
Open

Add v2.0 endpoint support #39

DimaGershman opened this issue Feb 15, 2018 · 0 comments

Comments

@DimaGershman
Copy link

Hi @HNeukermans ,
I've seen there is an old PR #27 on the same subject that looks stuck... From directly modifying the generates JS at dist/, it looks like the change is fairly minor:

instead of '/oauth2/authorize' use '/oauth2/v2.0/authorize' in UrlBuilder classes.
Of course it should be backwards compatible, so adding a parameter to AdalConfig makes sense to me.

I am sorry to admit that I gave up on making it as PR after an hour of fighting with Karma & other environment things that just wouldn't stop giving me errors from npm :(

P.S. Thank You for the library !!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant