Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

增加对 IOServer 依赖注入的测试 #21

Merged
merged 1 commit into from
Dec 3, 2023

Conversation

yrris
Copy link

@yrris yrris commented Dec 3, 2023

I've added Spring's dependency injection framework to the project's pom.xml and attempted to implement dependency injection for IOServer using the Spring container. In the IOServerTest test file, I successfully tested the injection of the ColorSetting object into IOServer. This is just a small part of the work. Given the large scale of the entire project, fully refactoring to manage dependency injection through the framework seems challenging for me at this stage.

Copy link
Contributor

@FerdinandSu FerdinandSu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful! This is almost the most valuable PR recently. This is a great improvement for JMoblieSuit!

@FerdinandSu FerdinandSu merged commit 7a056cb into HIT-ReFreSH:master Dec 3, 2023
@FerdinandSu FerdinandSu mentioned this pull request Dec 3, 2023
@FerdinandSu FerdinandSu added enhancement New feature or request Great Improvement labels Dec 3, 2023
@FerdinandSu FerdinandSu added this to the Dependency Injection milestone Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Great Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants