Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Unticketed] Upgrade Analytics code to Python 3.13 #2894

Merged
merged 4 commits into from
Nov 18, 2024

Conversation

chouinar
Copy link
Collaborator

Summary

Time to review: 3 mins

Changes proposed

Upgrade Analytics to Python 3.13

Context for reviewers

The API has already done this upgrade, Python 3.13 has very few impactful changes (mostly experimental features you need to enable). Doing this to try to resolve some build issues I'm seeing in CI/CD, especially regarding the renovate upgrades that are being attempted: #1994

coilysiren
coilysiren previously approved these changes Nov 18, 2024
Copy link
Collaborator

@coilysiren coilysiren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:thank-you: 🚀

@coilysiren
Copy link
Collaborator

Oh no it's broken

And it's broken on python 3.13 specially! Wow

@chouinar
Copy link
Collaborator Author

Apparently one library that there is a dependency for relies on Python 3.12 and earlier. Yay

@chouinar chouinar marked this pull request as draft November 18, 2024 14:59
@chouinar chouinar marked this pull request as ready for review November 18, 2024 15:36
@chouinar
Copy link
Collaborator Author

Did a very rough upgrade of packages with poetry update - won't have changed anything that had more restrictive versioning than just wanting the latest. Had to fix a few other minor things here and there to get everything happy.

Will rely on Renovate to handle any further package upgrades

@chouinar chouinar merged commit defe937 into main Nov 18, 2024
14 checks passed
@chouinar chouinar deleted the chouinar/analytics-python313 branch November 18, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants