diff --git a/.github/workflows/cd-frontend.yml b/.github/workflows/cd-frontend.yml index ca473911e..aac58f53d 100644 --- a/.github/workflows/cd-frontend.yml +++ b/.github/workflows/cd-frontend.yml @@ -33,7 +33,7 @@ jobs: uses: ./.github/workflows/deploy.yml strategy: matrix: - envs: ${{ github.event_name == 'release' && fromJSON('["prod"]') || github.ref_name == 'main' && fromJSON('["dev", "staging"]') || fromJSON('["dev"]') }} + envs: ${{ github.event_name == 'release' && fromJSON('["prod"]') || github.ref_name == 'main' && fromJSON('["dev"]') || fromJSON('["dev"]') }} # temporarily removing staging from matrix. See: https://github.com/HHS/simpler-grants-gov/issues/1919 with: app_name: "frontend" environment: ${{ matrix.envs }} diff --git a/documentation/wiki/product/deliverables/specifications/delivery-dashboard.md b/documentation/wiki/product/deliverables/specifications/delivery-dashboard.md index 28b5a0ffa..0ff542bb8 100644 --- a/documentation/wiki/product/deliverables/specifications/delivery-dashboard.md +++ b/documentation/wiki/product/deliverables/specifications/delivery-dashboard.md @@ -6,7 +6,7 @@ description: Create a public-facing dashboard with sprint and delivery metrics. ## Summary details -
FieldValue
Deliverable statusPlanning
Link to GitHub issueIssue 65
Key sections
+
FieldValue
Deliverable statusIn Progress
Link to GitHub issueIssue 65
Key sections
## Overview @@ -161,7 +161,7 @@ These stakeholders will likely be asking the following questions: Major updates to the content of this page will be added here. -
DateUpdateNotes
4/5/2024Added change log and implementation logThis is part of the April onsite follow-up
4/9/2024Incorporated comments on change request
  • Changes to "Definition of done"

    • Removed "Sprint Allocation" as a metric previously required for the dashboard
    • Moved public access to data to nice to have
  • Changes to "Proposed metrics"

    • Removed "Build time"
    • Added "Number of failures to load data"
  • Changes to "Technical descriptions":

    • Added additional considerations to decision drivers for dashboard UI
  • Changes to "User stories":

    • Added story for open source contributors wanting to see their impact on metrics
    • Added story for seeing last updated date on dashboard
4/10/2024Moved part of the content of this spec into a technical spec

Moved the following into this spec:

  • Integrations
  • Technical descriptions
+
DateUpdateNotes
4/5/2024Added change log and implementation logThis is part of the April onsite follow-up
4/9/2024Incorporated comments on change request
  • Changes to "Definition of done"

    • Removed "Sprint Allocation" as a metric previously required for the dashboard
    • Moved public access to data to nice to have
  • Changes to "Proposed metrics"

    • Removed "Build time"
    • Added "Number of failures to load data"
  • Changes to "Technical descriptions":

    • Added additional considerations to decision drivers for dashboard UI
  • Changes to "User stories":

    • Added story for open source contributors wanting to see their impact on metrics
    • Added story for seeing last updated date on dashboard
4/10/2024Moved part of the content of this spec into a technical spec

Moved the following into this spec:

  • Integrations
  • Technical descriptions
5/6/2024Moved deliverable status to "In Progress"
### Implementation log diff --git a/frontend/src/app/layout.tsx b/frontend/src/app/layout.tsx index 707c3ad10..d4530f285 100644 --- a/frontend/src/app/layout.tsx +++ b/frontend/src/app/layout.tsx @@ -32,9 +32,7 @@ export default function RootLayout({ children }: LayoutProps) { {/* TODO: Add locale="english" prop when ready for i18n */} {children} - {process.env.NEXT_PUBLIC_ENVIRONMENT === "prod" && ( - - )} + ); } diff --git a/frontend/src/constants/environments.ts b/frontend/src/constants/environments.ts index 01ab36724..e34df5594 100644 --- a/frontend/src/constants/environments.ts +++ b/frontend/src/constants/environments.ts @@ -4,15 +4,12 @@ */ const PUBLIC_ENV_VARS_BY_ENV = { development: { - GOOGLE_TAG_MANAGER_ID: "GTM-MV57HMHS", - GOOGLE_ANALYTICS_ID: "G-6MDCC5EZW2", + GOOGLE_ANALYTICS_ID: "G-GWJZD3DL8W", }, test: { - GOOGLE_TAG_MANAGER_ID: "GTM-MV57HMHS", GOOGLE_ANALYTICS_ID: "G-6MDCC5EZW2", }, production: { - GOOGLE_TAG_MANAGER_ID: "GTM-MV57HMHS", GOOGLE_ANALYTICS_ID: "G-6MDCC5EZW2", }, } as const; diff --git a/frontend/src/pages/_app.tsx b/frontend/src/pages/_app.tsx index 5cf80b206..971a5530f 100644 --- a/frontend/src/pages/_app.tsx +++ b/frontend/src/pages/_app.tsx @@ -1,7 +1,7 @@ import "../styles/styles.scss"; import type { AppProps } from "next/app"; -import { GoogleTagManager } from "@next/third-parties/google"; +import { GoogleAnalytics } from "@next/third-parties/google"; import Head from "next/head"; import Layout from "../components/Layout"; import { PUBLIC_ENV } from "src/constants/environments"; @@ -19,9 +19,7 @@ function MyApp({ Component, pageProps }: AppProps) { - {process.env.NEXT_PUBLIC_ENVIRONMENT === "prod" && ( - - )} + ); diff --git a/frontend/tests/components/search/SearchFilterAccordion/SearchFilterAccordion.test.tsx b/frontend/tests/components/search/SearchFilterAccordion/SearchFilterAccordion.test.tsx index 65934258e..553864683 100644 --- a/frontend/tests/components/search/SearchFilterAccordion/SearchFilterAccordion.test.tsx +++ b/frontend/tests/components/search/SearchFilterAccordion/SearchFilterAccordion.test.tsx @@ -108,10 +108,10 @@ describe("SearchFilterAccordion", () => { ); const accordionToggleButton = screen.getByTestId( - "accordionButton_funding-instrument-filter", + "accordionButton_funding-instrument-filter-status", ); const contentDiv = screen.getByTestId( - "accordionItem_funding-instrument-filter", + "accordionItem_funding-instrument-filter-status", ); expect(contentDiv).toHaveAttribute("hidden");