fix typespecs, replace mentat with cachex, fix flaky test, improve docs #38
Conversation
|
@andyleclair, thanks for the contributions. I have been thinking we need to replace Mentat. |
|
I saw that linting step failed, it may be a few days until I can resolve that, my wife and I are about to go to the hospital to have a baby 😅 |
| @@ -37,9 +37,11 @@ defmodule Avalanche.TokenCacheTest do | |||
| -----END PRIVATE KEY----- | |||
| """ | |||
|
|
|||
| setup :set_mimic_global | |||
There was a problem hiding this comment.
do we need this one? We are about to move away from Mimic. If we do, no worries and we will tackle this later
There was a problem hiding this comment.
I think this was for the flaky tests. Let's leave it and remove when we remove Mimic.
There was a problem hiding this comment.
Yes, mimic doesn't work great across process boundaries, which it would be doing here in the call to the token cache
We got you! Your wife and baby are a priority! |
|
@andyleclair thanks for doing this! Congrats on the baby! ❤️ |
|
🎉 This PR is included in version 0.11.6 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
Thank you both! |
Hi! First, thank you so much for this library! ODBC is a real pain, and it doesn't work with non-ASCII characters in a query.
I wanted to submit this to you because I know Keathley can be a bit slow, and since people have been waiting months for a proper Mentat release that matches
main, I don't want to hold my breath about it. I've used Cachex, and it's a perfectly usable replacement. I've set the cache options to match Mentat, so it won't change any behavior of the janitor timing.I also fixed a few typespecs (
tokenwas listed as onlybinarywhen it could also bekeyword), updated the docs for thetokenauth parameter, and I fixed a flaky test caused by usingMimicacross process boundaries.Please let me know if you're interested in accepting any of these changes! Thanks again!