Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibilities with future pyuvdata #401

Closed
bhazelton opened this issue May 16, 2024 · 2 comments
Closed

Incompatibilities with future pyuvdata #401

bhazelton opened this issue May 16, 2024 · 2 comments

Comments

@bhazelton
Copy link
Member

We don't have a CI job set up on pyuvdata to run hera_pspec (although I'm happy to help someone set one up), so I wasn't really tracking the impact of pyuvdata developments on hera_pspec (unlike hera_cal and hera_qm). But I just grabbed the repo and it looks like a lot of tests are failing when run against the pyuvdata prep_v3.0 branch. At a quick glance it looks like the bulk of the errors are related to a change @steven-murray made to return slices when possible from key2inds, but there also a few that seem to be related to other things.

@steven-murray fixed a set of related errors on hera_cal and hera_qm, so he may be able to help here, but I think it'd be good for someone who uses hera_pspec regularly to be tracking this.

@adeliegorce
Copy link
Contributor

I think this got incidentally fixed through #402 and now hera_pspec is running with (and breaking without) pyuvdata>=3.0

@steven-murray
Copy link
Contributor

Yup, that was part of the plan in that PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants