Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lack of backward compatibility for non-future_array_shape in utils.uvd_to_Tsys #396

Closed
JianrongTan opened this issue Mar 5, 2024 · 4 comments · Fixed by #397
Closed

Lack of backward compatibility for non-future_array_shape in utils.uvd_to_Tsys #396

JianrongTan opened this issue Mar 5, 2024 · 4 comments · Fixed by #397
Assignees
@adeliegorce

Comments

@JianrongTan
Copy link
Collaborator

In utils.uvd_to_Tsys, this line doesn't work if uvd is not using future_array_shape

uvd.data_array[tinds, :, pind] *= J2K[pol]
@adeliegorce adeliegorce mentioned this issue Mar 5, 2024
Merged
@adeliegorce adeliegorce linked a pull request Mar 5, 2024 that will close this issue
Added tests re. future array shapes and ensured compatibility in utils #397
Merged
@adeliegorce
Copy link
Contributor

Thank you for pointing this out. This issue is addressed in PR#397.

@adeliegorce
Copy link
Contributor

adeliegorce commented Mar 5, 2024 •
edited
Loading

@JianrongTan @lisaleemcb could you re-run your pipeline in the future-array-shapes-bug branch and let me know if the changes I made fixed your issue?

@JianrongTan
Copy link
Collaborator Author

Thanks @adeliegorce! I have tested with the updated code and the issue is solved.

@adeliegorce
Copy link
Contributor

Great! Could you review the associated PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adeliegorce adeliegorce

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added tests re. future array shapes and ensured compatibility in utils HERA-Team/hera_pspec
2 participants
@adeliegorce @JianrongTan