Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue in little_h homogeneity when using grouping.spherical_average #361

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

adeliegorce
Copy link
Contributor

@adeliegorce adeliegorce commented Jul 7, 2022

There was an issue in grouping.spherical_average: if keyword little_h is False in function, then the input k-bins are automatically adjusted to be in h Mpc-1 units:

# transform kgrid to little_h units
 if not little_h:
      kbins = kbins / uvp.cosmo.h
      bin_widths = bin_widths / uvp.cosmo.h

However this change occurred after defining kbin_left and kbin_right that are later used to bin. I changed this and moved the above code block up.

@adeliegorce adeliegorce linked an issue Dec 16, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure little_h consistency throughout
1 participant