Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for pstokes in the pol_pairs arg of pspec_run if we use an efield beam. #325

Open
aewallwi opened this issue Mar 24, 2021 · 1 comment

Comments

@aewallwi
Copy link
Collaborator

aewallwi commented Mar 24, 2021

If we include pstokes in the pol_pairs arg of pspec_run (e.g. [(pI, pI)]) we get an error because pspecbeam.PSpecBeamUV uses efield_to_power rather then efield_to_pstokes when initializing its uvbeam object so it does not contain any information on the pstokes beams.

self.primary_beam.efield_to_power(inplace=True)

Using efield_to_pstokes will not support linear pol power spectra though (maybe I'm wrong about this?) so I propose including a copy of self.primary_beam in pspecbeam.PSPecBeamUV called self.pstokes_primary_beam that stores the pstokes pols and gets referred to when computing Omegap and Omegapp for pstokes pols.

@aewallwi aewallwi changed the title pstokes pol_pairs cause errors Support for pstokes in the pol_pairs arg of pspec_run. Mar 24, 2021
@aewallwi aewallwi changed the title Support for pstokes in the pol_pairs arg of pspec_run. Support for pstokes in the pol_pairs arg of pspec_run if we use an efield beam. Mar 24, 2021
@nkern
Copy link
Member

nkern commented Mar 24, 2021

You should be using a pI power beam to normalize the power spectra. and if you want to use X or Y power beam for power spectra, you should be able to get it with existing infrastructure between pyuvdata and hera_pspec without having to make a copy of the beam itself. whether pspec_run knows how to do this is another thing, I think, but in principle the tools should exist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants