Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileCredentials() doesn't support credentials retrieved with AWS CLI v2 #187

Open
jonathanunderwood opened this issue Jun 30, 2024 · 1 comment

Comments

@jonathanunderwood
Copy link

jonathanunderwood commented Jun 30, 2024

It appears that FileCredentials expects to see credentials at ~/.aws/credentials. However, with recent versions of the AWS CLI, this file isn't populated, for example, when authenticating via aws sso login. This behaviour change has been discussed at length here: aws/aws-cli#4982. This article discusses more about why relying on .aws/credentials isn't the right approach.

Would it be possible to update FileCredentials to leverage credential_process?

@ojii
Copy link
Contributor

ojii commented Jul 1, 2024

Two things:

You can tell FileCredentials where to look for the credentials file by passing it a path as its first argument.

credential process is unrelated to FileCredential. I would probably accept a PR that added a credentials loader that supports a credential process, but in the meantime, aiodynamo supports custom credential providers so you can write an implementation that works for you without relying on me merging a PR and releasing a new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants