From 01405c7df71c7aaa47a38b5d594e3d7b62658d69 Mon Sep 17 00:00:00 2001 From: Dana Robinson Date: Fri, 7 Jun 2024 12:31:26 -0700 Subject: [PATCH 1/3] Fix CI markdown link check http 500 errors Sites like GitLab can have internal problems that return http 500 errors while they fix their problems. This PR adds a config file to the markdown link check so those are considered "passing" and don't break the CI. --- .github/workflows/markdown-link-check.yml | 3 +++ .github/workflows/markdown_config.json | 3 +++ 2 files changed, 6 insertions(+) create mode 100644 .github/workflows/markdown_config.json diff --git a/.github/workflows/markdown-link-check.yml b/.github/workflows/markdown-link-check.yml index 00cb686c082..2ca6b530eb2 100644 --- a/.github/workflows/markdown-link-check.yml +++ b/.github/workflows/markdown-link-check.yml @@ -6,9 +6,12 @@ on: pull_request: branches: [ develop ] +# The config file handles things like http 500 errors from sites like GitLab jobs: markdown-link-check: runs-on: ubuntu-latest steps: - uses: actions/checkout@master - uses: gaurav-nelson/github-action-markdown-link-check@v1 + with: + config-file: 'markdown_config.json' diff --git a/.github/workflows/markdown_config.json b/.github/workflows/markdown_config.json new file mode 100644 index 00000000000..c43bc39fce9 --- /dev/null +++ b/.github/workflows/markdown_config.json @@ -0,0 +1,3 @@ +{ + "aliveStatusCodes": [500] +} From 98c46a60e78fe1c4ddfe6fc5e85403e1b7a878e3 Mon Sep 17 00:00:00 2001 From: Dana Robinson Date: Fri, 7 Jun 2024 12:38:49 -0700 Subject: [PATCH 2/3] Update config file path --- .github/workflows/markdown-link-check.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/markdown-link-check.yml b/.github/workflows/markdown-link-check.yml index 2ca6b530eb2..eecfdb96b30 100644 --- a/.github/workflows/markdown-link-check.yml +++ b/.github/workflows/markdown-link-check.yml @@ -14,4 +14,4 @@ jobs: - uses: actions/checkout@master - uses: gaurav-nelson/github-action-markdown-link-check@v1 with: - config-file: 'markdown_config.json' + config-file: '.github/workflows/markdown_config.json' From faac947d3e6fbcce367fa976cc7e858fab35afcf Mon Sep 17 00:00:00 2001 From: Dana Robinson Date: Fri, 7 Jun 2024 12:42:42 -0700 Subject: [PATCH 3/3] Add 200 to the list of acceptable responses --- .github/workflows/markdown-link-check.yml | 1 + .github/workflows/markdown_config.json | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/markdown-link-check.yml b/.github/workflows/markdown-link-check.yml index eecfdb96b30..6a18f0b5bd4 100644 --- a/.github/workflows/markdown-link-check.yml +++ b/.github/workflows/markdown-link-check.yml @@ -7,6 +7,7 @@ on: branches: [ develop ] # The config file handles things like http 500 errors from sites like GitLab +# and http 200 responses jobs: markdown-link-check: runs-on: ubuntu-latest diff --git a/.github/workflows/markdown_config.json b/.github/workflows/markdown_config.json index c43bc39fce9..1ae40f89e5a 100644 --- a/.github/workflows/markdown_config.json +++ b/.github/workflows/markdown_config.json @@ -1,3 +1,3 @@ { - "aliveStatusCodes": [500] + "aliveStatusCodes": [200, 500] }