Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge changes from PRs #425, 427, 428 to support branches. #435

Closed
lrknox opened this issue Mar 5, 2021 · 3 comments
Closed

Merge changes from PRs #425, 427, 428 to support branches. #435

lrknox opened this issue Mar 5, 2021 · 3 comments
Assignees

Comments

@lrknox
Copy link
Collaborator

lrknox commented Mar 5, 2021

Merge needed to hdf5_1_12, hdf5_1_10, and hdf5_1_8 as appropriate for PRs #425, 427, 428 after passing all test configurations in daily test cycle

#425 Fixes various warnings noticed on Windows
#427 Fixed clang-tidy readability-misleading-indentation warnings
#428 Fixed clang-tidy readability-redundant-control-flow warnings

@lrknox lrknox self-assigned this Mar 5, 2021
@lrknox lrknox added the merge label Mar 5, 2021
@lrknox
Copy link
Collaborator Author

lrknox commented Mar 10, 2021

PR #425 Fixes various warnings noticed on Windows was merged to hdf5_1_12 along with #427 Fixed clang-tidy readability-misleading-indentation warnings and #428 Fixed clang-tidy readability-redundant-control-flow warnings in PR #460.

#427 Fixed clang-tidy readability-misleading-indentation warnings and #428 Fixed clang-tidy readability-redundant-control-flow warnings were also merged to hdf5_1_10 in PR #462.

PR #425 Fixes various warnings noticed on Windows needs merging to hdf5_1_10. Assigning this to Dana.

None have been merged to hdf5_1_8 pending further discussion.

@seanm
Copy link
Contributor

seanm commented Jan 8, 2022

@lrknox @derobins sounds like this is mostly done?

@derobins derobins removed the merge label Jul 21, 2022
@byrnHDF
Copy link
Contributor

byrnHDF commented Nov 17, 2022

Will rely on branch compare as this is 1.5 years old.

@byrnHDF byrnHDF closed this as completed Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants