New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add handling for entries which exist only in old or new CSV #1

Merged

HCastano merged 3 commits into HCastano:master from cmichi:cmichi-handle-missing-entries-in-new-or-old

Nov 24, 2021

Contributor

cmichi commented Nov 24, 2021

This adds handling for those cases:

if an entry is only existent in the old csv
if an entry is only existent in the new csv

I found this while wondering why our regression bot didn't properly post the proxy results in use-ink/ink#1020. This is the job: https://gitlab.parity.io/parity/ink-waterfall/-/jobs/1241718.

cmichi added 3 commits

November 24, 2021 07:57


          Add handling for missing entries in old/new CSV

03080e7


          Apply cargo fmt

55e77ee


          Improve tests

c271a2e

HCastano approved these changes

View reviewed changes

Owner

HCastano left a comment

Thanks 🥇

HCastano merged commit 64d90cc into HCastano:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet