Skip to content

Latest commit

 

History

History
103 lines (72 loc) · 3.4 KB

CONTRIBUTING.md

File metadata and controls

103 lines (72 loc) · 3.4 KB
Raw

Contributing

Quick Links for Contributing

Coding Guidelines

  • Avoid trailing spaces. To view trailing spaces before making a commit, use "git diff" on your changes. If colors are enabled for git in the command prompt, it will show you any whitespace issues marked with red.

  • No Tabs, only Spaces, Space width is 2

Commit Guidelines

  • sogeBot uses the 50/72 standard for commits. 50 characters max for the title (excluding type), an empty line, and then a full description of the commit, wrapped to 72 columns max. See this link for more information: http://chris.beams.io/posts/git-commit/

  • Make sure commit titles are always in present tense, and are not followed by punctuation.

  • Keep second line blank.

  • Prefix commit titles with the type(scope?), followed by a colon and a space. So for example, if you are modifying the alias system:

    fix(alias): fix bug with parsing

    Or for donationalerts.ru integration:

    feat(donationalerts): fix source not displaying

    If you are updating non project files like CONTRIBUTING.md, travis.yml, use chore

    chore: update CONTRIBUTING.md

  • The header is mandatory and the scope of the header is optional.

  • Commit title should be entirely in lowercase with the exception of proper nouns, acronyms, and the words that refer to code, like function/variable names

  • If fixing issue, use Closes or Fixes keywords in commit description to link with issue or idea

    Example of full commit message:

    fix: explain the commit in one line

Body of commit message is a few lines of text, explaining things
in more detail, possibly giving some background about the issue
being fixed, etc.

The body of the commit message can be several paragraphs, and
please do proper word-wrap and keep columns shorter than about
72 characters or so. That way, `git log` will show things
nicely even when it is indented.

Fixes: https://github.com/sogehige/sogeBot/issues/1406

  • If you are updating locales, docs and doesn't fix bugs or add feature, you can add [skip-tests] to skip functional tests of bot into your Pull Request

  • If you still need examples, please view the commit history.

Commit types

Must be one of the following:

  • feat: A new feature
  • fix: A bug fix
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • refactor: A code change that neither fixes a bug nor adds a feature
  • perf: A code change that improves performance
  • test: Adding missing or correcting existing tests
  • chore: Changes to the build process or auxiliary tools and libraries such as documentation generation

Commit Squashing

In most cases, do not squash commits that you add to your Pull Request during the review process. When the commits in your Pull Request land, they may be squashed into one commit per logical change. Metadata will be added to the commit message (including links to the Pull Request, links to relevant issues, and the names of the reviewers). The commit history of your Pull Request, however, will stay intact on the Pull Request page.