We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I can't build mkdocs sites from repositories where commits are signed and git client is configured to always show commit signature.
git
The problem seems to be here:
mkdocs-rss-plugin/mkdocs_rss_plugin/util.py
Lines 145 to 159 in c9b1c8b
It assumes that git log -1 --date=short --format="%at"'s output will only contain the timestamp and nothing else, which isn't true.
git log -1 --date=short --format="%at"
My gitconfig contains:
[log] showSignature = true
Which is equivalent to git log --show-signature ..., and the output will always contain commit signature info:
git log --show-signature ...
$ git log --date=short -1 --format="%at" gpg: Signature made Tue Jun 21 17:19:48 2022 PDT gpg: using EDDSA key 90DA57F75A16D8729DBEE227CD67D78AC53D68C5 gpg: Good signature from "Yuhao Zhang <[email protected]>" [ultimate] 1655857188
And the plugin will crash at:
Lines 179 to 180 in c9b1c8b
Because the whole string cannot be converted to int.
int
The text was updated successfully, but these errors were encountered:
Really interesting use case!
Thanks for the PR! I'm gonna to review it right now.
Sorry, something went wrong.
Guts
Successfully merging a pull request may close this issue.
I can't build mkdocs sites from repositories where commits are signed and
git
client is configured to always show commit signature.The problem seems to be here:
mkdocs-rss-plugin/mkdocs_rss_plugin/util.py
Lines 145 to 159 in c9b1c8b
It assumes that
git log -1 --date=short --format="%at"
's output will only contain the timestamp and nothing else, which isn't true.My gitconfig contains:
Which is equivalent to
git log --show-signature ...
, and the output will always contain commit signature info:And the plugin will crash at:
mkdocs-rss-plugin/mkdocs_rss_plugin/util.py
Lines 179 to 180 in c9b1c8b
Because the whole string cannot be converted to
int
.The text was updated successfully, but these errors were encountered: