fix(tracing): Properly handle tracing fields that resolve an array of lazy values #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…irectly into the _entities resolver
rylanc
changed the title
rylanc
changed the title
noaelad
approved these changes
Jul 16, 2020
rylanc
pushed a commit
that referenced
this pull request
Jul 16, 2020
## [1.1.3](v1.1.2...v1.1.3) (2020-07-16) ### Bug Fixes * **tracing:** Properly handle tracing fields that resolve an array of lazy values ([#87](#87)) ([a9eed77](a9eed77))
|
🎉 This PR is included in version 1.1.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
mpospelov
pushed a commit
to toptal/apollo-federation-ruby
that referenced
this pull request
Aug 2, 2021
… lazy values (Gusto#87) * test: Add failing test * fix(tracing): Properly handle arrays of lazy values * refactor: Move EntityTypeResolutionExtension.after_resolve behavior directly into the _entities resolver * fix: Remove broken require; * style: Fix linter errors * test: Add more test cases * 🎨 Cleanup * Clarify todo * style: Fix linter error
mpospelov
pushed a commit
to toptal/apollo-federation-ruby
that referenced
this pull request
Aug 2, 2021
## [1.1.3](Gusto/apollo-federation-ruby@v1.1.2...v1.1.3) (2020-07-16) ### Bug Fixes * **tracing:** Properly handle tracing fields that resolve an array of lazy values ([Gusto#87](Gusto#87)) ([a9eed77](Gusto@a9eed77))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes tracing when returning a lazy value from an entity's
.resolve_referencemethod.