Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix spec to account for breaking change to graphql-ruby 1.10.0 #62

Merged
merged 1 commit into from
Apr 6, 2020

Conversation

kryptonat
Copy link
Contributor

Account for breaking change to graphql-ruby 1.10.0 in spec

Class-based schemas using the interpreter must add use GraphQL::Analysis::AST to their schema (and update their custom analyzers, see https://graphql-ruby.org/queries/ast_analysis.html) #2363

Copy link
Collaborator

@grxy grxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Mind adding a more descriptive PR title before merging for CHANGELOG purposes?

@kryptonat kryptonat changed the title fix: Fix spec fix: Fix spec to account for breaking change to graphql-ruby 1.10.0 Apr 6, 2020
@kryptonat kryptonat merged commit a631441 into master Apr 6, 2020
@kryptonat kryptonat deleted the nw-fix-specs branch April 6, 2020 17:14
rylanc pushed a commit that referenced this pull request Apr 6, 2020
## [1.0.4](v1.0.3...v1.0.4) (2020-04-06)

### Bug Fixes

* Fix spec to account for breaking change to graphql-ruby 1.10.0 ([#62](#62)) ([a631441](a631441))
@rylanc
Copy link
Contributor

rylanc commented Apr 6, 2020

🎉 This PR is included in version 1.0.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@rylanc rylanc added the released label Apr 6, 2020
@rylanc
Copy link
Contributor

rylanc commented May 11, 2020

In the future, PRs that only have test changes/fixes should be marked as a chore. Changes like this don't affect the released code and therefore don't need a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants