Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: import @inaccessible directive in Fed v2.3 #220

Merged
merged 1 commit into from
Feb 21, 2023

Conversation

moonflare
Copy link
Contributor

Description

Currently, due to different namespaces across multiple subgraphs, we are getting the following error:

LINK_IMPORT_NAME_MISMATCH: The federation "@inaccessible" directive is imported with mismatched name between subgraphs: it is imported as "@federation__inaccessible" in subgraphs "A" and "B" but "@inaccessible" in subgraphs "C", "D"...

According to prasek's comment here, we should always import the @inaccessible directive to avoid multiple namespaces. This PR address this.

@moonflare moonflare force-pushed the import-inaccessible-directive branch 3 times, most recently from c81112a to 7592028 Compare February 21, 2023 21:22
@grxy grxy changed the title fix: import @inaccessible directive in Fed v2.3 fix: import @inaccessible directive in Fed v2.3 Feb 21, 2023
@moonflare moonflare force-pushed the import-inaccessible-directive branch from 7592028 to e432cda Compare February 21, 2023 21:33
@moonflare moonflare force-pushed the import-inaccessible-directive branch from e432cda to 1e8280f Compare February 21, 2023 21:35
Copy link
Collaborator

@grxy grxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@grxy grxy merged commit 5d4d86e into Gusto:main Feb 21, 2023
grxy pushed a commit that referenced this pull request Feb 21, 2023
## [3.4.1](v3.4.0...v3.4.1) (2023-02-21)

### Bug Fixes

* import [@inaccessible](https://github.com/inaccessible) directive in Fed v2.3 ([#220](#220)) ([5d4d86e](5d4d86e))
@grxy
Copy link
Collaborator

grxy commented Feb 21, 2023

🎉 This PR is included in version 3.4.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@grxy grxy added the released label Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants