-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use Github App for authentication #216
Conversation
The new script will create an `INSTALLATION_ACCESS_TOKEN` scoped to this repo, and only valid for 1 hour. This will allow the semantic version step to no longer require a human's identity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add comments to the script explaining what is going on?
Yes! Sorry for the delay. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything else looks good. Will approve after a couple small typos are fixed.
🎉 This PR is included in version 3.5.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
* Use Github App for authentication The new script will create an `INSTALLATION_ACCESS_TOKEN` scoped to this repo, and only valid for 1 hour. This will allow the semantic version step to no longer require a human's identity. * add comments about how the script works * Update create_release.sh --------- Co-authored-by: Grex <[email protected]>
## [3.5.2](Gusto/apollo-federation-ruby@v3.5.1...v3.5.2) (2023-03-08) ### Reverts * Revert "chore: use Github App for authentication (Gusto#216)" (Gusto#227) ([f503704](Gusto@f503704)), closes [Gusto#216](Gusto#216) [Gusto#227](Gusto#227)
The new script will create an
INSTALLATION_ACCESS_TOKEN
scoped to this repo, and only valid for 1 hour.This will allow the semantic version step to no longer require a human's identity.