Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use Github App for authentication #216

Merged
merged 4 commits into from
Mar 8, 2023

Conversation

ethankhall
Copy link
Contributor

The new script will create an INSTALLATION_ACCESS_TOKEN scoped to this repo, and only valid for 1 hour.

This will allow the semantic version step to no longer require a human's identity.

The new script will create an `INSTALLATION_ACCESS_TOKEN` scoped to this
repo, and only valid for 1 hour.

This will allow the semantic version step to no longer require a human's
identity.
@ethankhall ethankhall requested review from grxy and lewhit January 6, 2023 20:56
Copy link
Collaborator

@grxy grxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add comments to the script explaining what is going on?

@ethankhall ethankhall requested a review from grxy January 10, 2023 18:45
@ethankhall
Copy link
Contributor Author

Yes! Sorry for the delay.

Copy link
Collaborator

@grxy grxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything else looks good. Will approve after a couple small typos are fixed.

.circleci/create_release.sh Outdated Show resolved Hide resolved
.circleci/create_release.sh Outdated Show resolved Hide resolved
@grxy grxy changed the title Use Github App for authentication chore: use Github App for authentication Jan 11, 2023
@grxy grxy merged commit bcc8b8d into main Mar 8, 2023
@grxy grxy deleted the ethankhall/use-github-app-for-release branch March 8, 2023 17:44
grxy added a commit that referenced this pull request Mar 8, 2023
grxy added a commit that referenced this pull request Mar 8, 2023
grxy pushed a commit that referenced this pull request Mar 8, 2023
## [3.5.2](v3.5.1...v3.5.2) (2023-03-08)

### Reverts

* Revert "chore: use Github App for authentication (#216)" (#227) ([f503704](f503704)), closes [#216](#216) [#227](#227)
@grxy
Copy link
Collaborator

grxy commented Mar 8, 2023

🎉 This PR is included in version 3.5.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@grxy grxy added the released label Mar 8, 2023
Kaytal pushed a commit to lensrentals/apollo-federation-ruby that referenced this pull request Oct 1, 2024
* Use Github App for authentication

The new script will create an `INSTALLATION_ACCESS_TOKEN` scoped to this
repo, and only valid for 1 hour.

This will allow the semantic version step to no longer require a human's
identity.

* add comments about how the script works

* Update create_release.sh

---------

Co-authored-by: Grex <[email protected]>
Kaytal pushed a commit to lensrentals/apollo-federation-ruby that referenced this pull request Oct 1, 2024
Kaytal pushed a commit to lensrentals/apollo-federation-ruby that referenced this pull request Oct 1, 2024
## [3.5.2](Gusto/apollo-federation-ruby@v3.5.1...v3.5.2) (2023-03-08)

### Reverts

* Revert "chore: use Github App for authentication (Gusto#216)" (Gusto#227) ([f503704](Gusto@f503704)), closes [Gusto#216](Gusto#216) [Gusto#227](Gusto#227)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants