addEnd returns incorrect end_col

[Varal7]

The current implementation of addEnd returns an incorrect end_col. It is based on the first_non_child of the node. I can't say I understand what is going on but the result is incorrect. For instance, using webdiff:

[jrfaller]

Hi! I tried to improve pythonparser some time ago. Can you try with the new version? Cheers!

[Varal7]

Hi, actually I’ve been using the PR I made in #2, which fixes this.

[jrfaller]

Wow awesome! I didn't know there was someone working on this since I do not go very often on pythonparser's repo. I committed the code but I am not the original author. Last commit I made was to make pythonparser compatible with the official GumTree XML exchange format to simplify its integration in GumTree. Along the way I simplified the code a bit and made some fixes. But surely, your version is better than mine, so it would make sense to replace my version by yours. Do you think you could adapt the output to produce a standard GumTree XML? I could help you to show you how it works (for instance it is explained here : GumTreeDiff/gumtree#164).

[jrfaller]

Closing this since we now use Parso for parsing.