-
-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Popups clipped by the window bounds #325
Comments
Thanks for filing this, @kirill-grouchnikov. I'm investigating this and the sidebar render overflow isn't related to the incorrectly-aligned The render overflow in the Sidebar can be solved by updating A render overflow in the Sidebar also happens for the An alternative solution to these render overflows would be to utilize the As for the incorrect alignment of the assert(menuLimits.top >= 0.0); I believe this assert is to ensure that the popup has enough space in the route to be shown properly. I'm not sure what the correct solution to this is. @whiplashoo do you have any thoughts on this? |
See #325 (comment) for more details
@GroovinChip Indeed, that's why it happens. Since the window height is not sufficient to display the pulldown menu, it defaults to being shown to (0.0, 0.0), in the top-left corner. Now, there is no good solution I can think for this. On native macOS apps, the pulldown menus are treated as separate windows; in Flutter, we can't draw outside the current window extent. That's why, when menus appear at the right corner, we opt, against native behavior, to draw it right-aligned to the window's edge: In Notes: If we could draw outside the window's extent with Flutter or implement the menus as separate windows, we would be able to display the pulldown menu at the same position every time. I haven't checked if there is any progress on this for Flutter desktop apps for a while. |
Thanks for confirming this, @whiplashoo. Yes, unfortunately there has been no discernible progress in the framework that would allow our popups to exceed the bounds of the window. In that light, do you have any thoughts on how we can prevent this incorrect behavior when the window height is so small? The only things I can think of are:
Frankly, I think option 3 is the best. |
Run the
example/lib/main.dart
and switch toe the "Toolbar" page. Now resize the app window to make it smaller than the default start and click one of the toolbar buttons that shows a popup:Two issues:
The text was updated successfully, but these errors were encountered: