Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error message for min and min-ex violations #195

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sdruskat
Copy link

@sdruskat sdruskat commented Sep 1, 2022

The errors are actually that a value is smaller than min or min-ex.

Fixes:

  • Changes error message to "less than"/"less than or equal to" instead of "greater than" for min and min-ex violations.

  • Changes error message to "greater than or equal to" instead of just "greater than" for max-ex violations.

  • Fixes Some error message for length violations are wrong #194

@Grokzen
Copy link
Owner

Grokzen commented Sep 1, 2022

@sdruskat Could you squash these smaller changes down into 1 commit instead? For this small of an change there dont need to be three commits

@sdruskat
Copy link
Author

sdruskat commented Sep 1, 2022

@Grokzen Sure, done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some error message for length violations are wrong
2 participants