Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename some mod.rs to <MOD_NAME>.rs #784

Merged
merged 2 commits into from
Dec 26, 2022
Merged

Conversation

discord9
Copy link
Contributor

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

rename mod.rs to each <module_name>.rs according to https://doc.rust-lang.org/reference/items/modules.html#module-source-filenames 's suggestion(Except for files in tests/ folder which are still using mod.rs)

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

@codecov
Copy link

codecov bot commented Dec 23, 2022

Codecov Report

Merging #784 (072bbfc) into develop (e07791c) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           develop     #784    +/-   ##
=========================================
  Coverage    85.42%   85.43%            
=========================================
  Files          414      415     +1     
  Lines        54230    54432   +202     
=========================================
+ Hits         46328    46506   +178     
- Misses        7902     7926    +24     
Flag Coverage Δ
rust 85.43% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/script/src/python/builtins.rs 87.12% <ø> (ø)
src/servers/src/mysql/handler.rs 59.84% <0.00%> (-4.55%) ⬇️
src/frontend/src/frontend.rs 38.88% <0.00%> (-1.12%) ⬇️
src/common/query/src/logical_plan/accumulator.rs 92.64% <0.00%> (-0.51%) ⬇️
src/query/src/query_engine/state.rs 85.05% <0.00%> (-0.38%) ⬇️
src/cmd/src/standalone.rs 49.54% <0.00%> (-0.23%) ⬇️
src/servers/src/lib.rs 100.00% <0.00%> (ø)
src/query/src/datafusion/planner.rs 66.66% <0.00%> (ø)
src/servers/src/interceptor.rs 81.08% <0.00%> (ø)
src/sql/src/parser.rs 81.40% <0.00%> (+0.04%) ⬆️
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This also fixes a task in #555

@evenyag evenyag merged commit e85780b into develop Dec 26, 2022
@evenyag evenyag deleted the remove_mod_rs branch December 26, 2022 04:48
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
* refactor: rename `mod.rs` to <MOD_NAME>.rs

* refactor: not rename mod.rs in benches/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants