Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix compiler errors in query crate #746

Merged
merged 12 commits into from
Dec 14, 2022
Merged

fix: Fix compiler errors in query crate #746

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
85801f2
fix: Fix compiler errors in state.rs
evenyag Dec 13, 2022
623c086
fix: fix compiler errors in state
evenyag Dec 13, 2022
b555cab
feat: upgrade sqlparser to 0.26
evenyag Dec 13, 2022
1714716
fix: fix datafusion engine compiler errors
evenyag Dec 13, 2022
6c1a558
fix: Fix some tests in query crate
evenyag Dec 13, 2022
38b8921
fix: Fix all warnings in tests
evenyag Dec 13, 2022
944d72d
feat: Remove `Type` from timestamp's type name
evenyag Dec 14, 2022
9ae41ad
fix: fix query tests
evenyag Dec 14, 2022
a909615
style: Fix clippy
evenyag Dec 14, 2022
b9f994a
feat: Remove RecordBatch::pretty_print
evenyag Dec 14, 2022
df74545
chore: Address CR comments
evenyag Dec 14, 2022
2097677
Update src/query/src/query_engine/state.rs
waynexia Dec 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 7 additions & 15 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion src/common/function/src/scalars.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,5 @@ pub(crate) mod test;
mod timestamp;
pub mod udf;

pub use aggregate::MedianAccumulatorCreator;
pub use function::{Function, FunctionRef};
pub use function_registry::{FunctionRegistry, FUNCTION_REGISTRY};
3 changes: 0 additions & 3 deletions src/common/function/src/scalars/aggregate.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ mod argmax;
mod argmin;
mod diff;
mod mean;
mod median;
mod percentile;
mod polyval;
mod scipy_stats_norm_cdf;
Expand All @@ -29,7 +28,6 @@ pub use argmin::ArgminAccumulatorCreator;
use common_query::logical_plan::AggregateFunctionCreatorRef;
pub use diff::DiffAccumulatorCreator;
pub use mean::MeanAccumulatorCreator;
pub use median::MedianAccumulatorCreator;
pub use percentile::PercentileAccumulatorCreator;
pub use polyval::PolyvalAccumulatorCreator;
pub use scipy_stats_norm_cdf::ScipyStatsNormCdfAccumulatorCreator;
Expand Down Expand Up @@ -88,7 +86,6 @@ impl AggregateFunctions {
};
}

register_aggr_func!("median", 1, MedianAccumulatorCreator);
register_aggr_func!("diff", 1, DiffAccumulatorCreator);
register_aggr_func!("mean", 1, MeanAccumulatorCreator);
register_aggr_func!("polyval", 2, PolyvalAccumulatorCreator);
Expand Down
287 changes: 0 additions & 287 deletions src/common/function/src/scalars/aggregate/median.rs
View file
Open in desktop

This file was deleted.

Loading