-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: support distinct JSON format and improve type conversions #4979
Conversation
WalkthroughThe changes in this pull request primarily focus on enhancing the handling of JSON and binary data types within the data type conversion logic. Key modifications include clearer distinctions between Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
@coderabbitai summary |
✅ Actions performedSummary regeneration triggered. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4979 +/- ##
==========================================
- Coverage 84.06% 83.82% -0.24%
==========================================
Files 1144 1144
Lines 213143 213171 +28
==========================================
- Hits 179176 178694 -482
- Misses 33967 34477 +510 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
support distinct JSON format and improve type conversions
Checklist
Summary by CodeRabbit
Release Notes
New Features
ConcreteDataType
for casting toJsonType
.Bug Fixes
Improvements