Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supports auto as values for all numeric configurations with default settings #4497

Open
killme2008 opened this issue Aug 3, 2024 · 0 comments
Labels
C-enhancement Category Enhancements good first issue Good for newcomers

Comments

@killme2008
Copy link
Contributor

What type of enhancement is this?

Configuration

What does the enhancement do?

The numeric configurations like

global_write_buffer_size = "1GB"

It has a default value that depends on system memory, but we hard-coded it in the sample configuration, it's not expected.

I create a PR #4495 to comment out all of them. But a better way is to make them support auto as the default value just like

mem_threshold_on_create = "auto"

Implementation challenges

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category Enhancements good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant