Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debug level traces in mito engine #4480

Open
WenyXu opened this issue Aug 1, 2024 · 2 comments
Open

Add debug level traces in mito engine #4480

WenyXu opened this issue Aug 1, 2024 · 2 comments
Labels
C-enhancement Category Enhancements good first issue Good for newcomers

Comments

@WenyXu
Copy link
Member

WenyXu commented Aug 1, 2024

What type of enhancement is this?

Other

What does the enhancement do?

GreptimeDB exports all collected spans using the gRPC-based OTLP protocol (see also).

However, current traces are still not good enough for performance debugging, consider adding more detailed spans in the mito engine. e.g., The time reading bytes from S3, The time building reader, etc.

Implementation challenges

No response

@WenyXu WenyXu added C-enhancement Category Enhancements good first issue Good for newcomers labels Aug 1, 2024
@Michaelin007
Copy link

Hi @WenyXu , I would like to work on this. Can you provide more insight into the problem?

@WenyXu
Copy link
Member Author

WenyXu commented Aug 19, 2024

Hi @WenyXu , I would like to work on this. Can you provide more insight into the problem?

Hey, I suggest starting with our tracing tutorials. Run a query and check out the traces—you'll probably notice they’re a bit too coarse. For example, we don't really see how much time is spent on things like downloading files or building readers. This issue is about improving that by adding more detailed, debug-level traces in the Mito engine, especially for queries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category Enhancements good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants