Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/case insensitive name #76

Merged
merged 3 commits into from
Apr 30, 2021

Conversation

VLuisa
Copy link
Contributor

@VLuisa VLuisa commented Apr 30, 2021

Resolves #72

  • Using ilike operator to match case insensitive regular expressions for firstName and lastName
  • Refactored Planter to use filter object instead of string

image

@VLuisa
Copy link
Contributor Author

VLuisa commented Apr 30, 2021

@nmcharlton Ah I didn't check the tests, and I see now it's looking for the getBackloopString() function I removed... Should I update the test? [edit: Took a stab at updating the test]

it('getBackloopString() should be: ', () => {
    expect(filterPlanter.getBackloopString()).toEqual(
      expect.stringContaining('&filter[where][personId]=1'),
    );
    ...

@VLuisa VLuisa marked this pull request as draft April 30, 2021 01:07
@VLuisa VLuisa marked this pull request as ready for review April 30, 2021 01:29
Copy link
Collaborator

@nmcharlton nmcharlton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work, thanks @VLuisa!

@nmcharlton nmcharlton merged commit e6577e0 into Greenstand:master Apr 30, 2021
@VLuisa VLuisa deleted the feature/case-insensitive-name branch April 30, 2021 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Planter name filter should be case-insensitive
2 participants