feat: add disabled save button if userName not unique #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmcharlton
reviewed
Feb 25, 2021
| helperText={ | ||
| handleError(userEditing, ['userName']) ? 'No space allowed' : '' | ||
| handleError(userEditing, ['userName']) | ||
| ? 'No space allowed' |
There was a problem hiding this comment.
This chained ternary operation is quite difficult to read.
At the very least, it needs to parentheses to make it clearer, but would benefit from being split out into a function.
src/components/Users.js
Outdated
| setUserEditing({ ...userEditing, userName: e.target.value }); | ||
| } | ||
|
|
||
| function handleUniqueUsername(e) { | ||
| setUserNameValid(true); | ||
| users.forEach((user) => { |
There was a problem hiding this comment.
This could be made more efficient using Array.find:
if (users.find((user) => user.userName === e.target.value) {
setUserNameValid(false);
} else {
setUserNameValid(true);
}
dadiorchen
approved these changes
Feb 26, 2021
|
Awesome, Thank you for the feedback. |
|
@zato91 No need to close the PR, just push any additional changes to the branch and they will automatically be included in this PR. |
|
line 407- refactored function handleUniqueUsername |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
line 143 add Boolean state userNameValid
line 407 add function HandleUniqueUsername to check duplicate
line 403 called handleUniqueUserName in handleUserNameChange function
line 633 add condition !userNameValid in error
line 634 add condition userNamevalid in helperText
line 795 add !userNameValid to disabled save button