Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add capture tags to Captures table #237

Merged
merged 3 commits into from
Dec 19, 2021

Conversation

tranquanghuy0801
Copy link
Member

@tranquanghuy0801 tranquanghuy0801 commented Dec 8, 2021

Description

Add Capture Tags to Captures table

Issue(s) addressed

What kind of change(s) does this PR introduce?

  • Enhancement
  • Bug fix
  • Refactor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Issue

What is the current behavior?

Don't have the Capture Tags column in Captures table

What is the new behavior?

New Capture Tags column in Captures table

Breaking change

Does this PR introduce a breaking change?

No

Other useful information

Copy link
Member

@Siddhant-K-code Siddhant-K-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@nmcharlton
Copy link
Collaborator

@tranquanghuy0801 This looks good. The only thing missing is Additional tags, which aren't part of the trees LoopBack model, so we have to request them separately using treeTrackerApi::getCaptureTags().
It would be good to try to add these for the listed captures and see what the performance is like.

If that doesn't work well, we may need to modify the API to always return those tags with the capture.

@nmcharlton
Copy link
Collaborator

@tranquanghuy0801 This looks good. The only thing missing is Additional tags, which aren't part of the trees LoopBack model, so we have to request them separately using treeTrackerApi::getCaptureTags(). It would be good to try to add these for the listed captures and see what the performance is like.

If that doesn't work well, we may need to modify the API to always return those tags with the capture.

@tranquanghuy0801 I can take a look at adding in the Additional Tags to the list.

@nmcharlton nmcharlton marked this pull request as draft December 19, 2021 13:27
@nmcharlton nmcharlton marked this pull request as ready for review December 19, 2021 13:57
@nmcharlton
Copy link
Collaborator

image

@nmcharlton nmcharlton merged commit 770e034 into Greenstand:master Dec 19, 2021
mitia-anah pushed a commit to mitia-anah/treetracker-admin-client that referenced this pull request Feb 1, 2022
* feat: add capture tags to Captures table

* feat(captures table): add capture tags to captures table

* fix: ensure tag lookup is populated

Co-authored-by: Nick Charlton <[email protected]>
Ny-Rianala pushed a commit to Ny-Rianala/treetracker-admin-client that referenced this pull request Feb 10, 2022
* feat: add capture tags to Captures table

* feat(captures table): add capture tags to captures table

* fix: ensure tag lookup is populated

Co-authored-by: Nick Charlton <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add capture tags to Captures list
3 participants