-
-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add capture tags to Captures table #237
Conversation
7ce8415
to
caf44f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
@tranquanghuy0801 This looks good. The only thing missing is Additional tags, which aren't part of the If that doesn't work well, we may need to modify the API to always return those tags with the capture. |
@tranquanghuy0801 I can take a look at adding in the Additional Tags to the list. |
* feat: add capture tags to Captures table * feat(captures table): add capture tags to captures table * fix: ensure tag lookup is populated Co-authored-by: Nick Charlton <[email protected]>
* feat: add capture tags to Captures table * feat(captures table): add capture tags to captures table * fix: ensure tag lookup is populated Co-authored-by: Nick Charlton <[email protected]>
Description
Add Capture Tags to Captures table
Issue(s) addressed
What kind of change(s) does this PR introduce?
Please check if the PR fulfills these requirements
Issue
What is the current behavior?
Don't have the Capture Tags column in Captures table
What is the new behavior?
New Capture Tags column in Captures table
Breaking change
Does this PR introduce a breaking change?
No
Other useful information