fix: display Full Capture Details in Verify and Captures pages #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tranquanghuy0801
changed the title
nmcharlton
requested changes
Dec 12, 2021
There was a problem hiding this comment.
This is good, but it doesn't address the whole problem.
In particular, we still don't see the capture tags (AKA treeTags).
See my comments in the issue for how to resolve that part:
I can see a couple of things causing this:
- We're not wrapping these views with
CaptureDetailProvidertags- We don't return capture from
CaptureDetailContext::getCapture()so it can't be passed to subsequent queries
nmcharlton
reviewed
Dec 12, 2021
nmcharlton
approved these changes
Dec 15, 2021
There was a problem hiding this comment.
@tranquanghuy0801 I hope you don't mind, I've made the changes myself so we can get the fix into the next build. Thanks for your work on this!
@nmcharlton That's alright. I totally understand. Happy to have a new release. |
mitia-anah
pushed a commit
to mitia-anah/treetracker-admin-client
that referenced
this pull request
Feb 1, 2022
…stand#228) * fix: display species and other tags in capture details in Verify and Captures pages * fix: restore species/tags to capture detail dialog Co-authored-by: Nick Charlton <[email protected]>
Ny-Rianala
pushed a commit
to Ny-Rianala/treetracker-admin-client
that referenced
this pull request
Feb 10, 2022
…stand#228) * fix: display species and other tags in capture details in Verify and Captures pages * fix: restore species/tags to capture detail dialog Co-authored-by: Nick Charlton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…Captures pages
Description
This PR fixed the issue of not displaying full species and other tags in Capture Detail Dialog.
Issue(s) addressed
What kind of change(s) does this PR introduce?
Please check if the PR fulfills these requirements
Issue
What is the current behavior?
Not display the species tags in Captures page, and not display the species tags and the other tags in Verify page
What is the new behavior?
Both species and other tags are displayed fully in Verify and Captures pages.
Breaking change
Does this PR introduce a breaking change?
No breaking change
Other useful information