Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: copy button for CaptureID in Capture Detail Dialog #224

Merged
merged 1 commit into from
Dec 1, 2021

Conversation

tranquanghuy0801
Copy link
Member

Description

Fix the copy button of CaptureID in Capture Detail Dialog

Issue(s) addressed

What kind of change(s) does this PR introduce?

  • Enhancement
  • Bug fix
  • Refactor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Issue

What is the current behavior?
Click button to copy the CaptureID in Capture Detail Dialog causes an error

What is the new behavior?
Click button to copy the CaptureID in Capture Detail Dialog is now working normally

Breaking change

Does this PR introduce a breaking change?

No

Other useful information

@tranquanghuy0801 tranquanghuy0801 requested a review from a team as a code owner December 1, 2021 07:03
@tranquanghuy0801 tranquanghuy0801 changed the title fix: pass the confirmCopy function to CopyButton for CaptureID fix: copy button for CaptureID in Capture Detail Dialog Dec 1, 2021
Copy link

@ronaldsmartin ronaldsmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@nmcharlton nmcharlton merged commit 196ce3c into Greenstand:master Dec 1, 2021
@tranquanghuy0801 tranquanghuy0801 deleted the fix-223 branch December 1, 2021 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Click the button to copy CaptureID in Capture Detail Dialog causes an error
3 participants