Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Capture counts to Grower Details dialog #222

Merged
merged 7 commits into from
Dec 12, 2021

Conversation

tranquanghuy0801
Copy link
Member

@tranquanghuy0801 tranquanghuy0801 commented Nov 30, 2021

Description

[Add a description of the changes]
Added the Capture counts to Grower Detail dialog.

Issue(s) addressed

What kind of change(s) does this PR introduce?

  • Enhancement
  • Bug fix
  • Refactor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Issue

What is the current behavior?
The current Grower Detail dialog does not have the associated Capture counts

What is the new behavior?
The current Grower Detail dialog will have the associated Capture counts

Breaking change

Does this PR introduce a breaking change?
No

Other useful information

Screenshot

image

@tranquanghuy0801 tranquanghuy0801 marked this pull request as ready for review December 1, 2021 03:41
@tranquanghuy0801 tranquanghuy0801 requested a review from a team as a code owner December 1, 2021 03:41
Copy link
Collaborator

@nmcharlton nmcharlton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The UI looks great, but these aren't the right counts.
We need to query the API for each count against this grower.

src/components/GrowerDetail.js Outdated Show resolved Hide resolved
@tranquanghuy0801
Copy link
Member Author

@nmcharlton I made the changes based on your suggestions. Please check my work, thanks

src/components/GrowerDetail.js Outdated Show resolved Hide resolved
src/views/GrowersView.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@nmcharlton nmcharlton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic work, thanks @tranquanghuy0801!

@nmcharlton nmcharlton merged commit 3528683 into Greenstand:master Dec 12, 2021
mitia-anah pushed a commit to mitia-anah/treetracker-admin-client that referenced this pull request Feb 1, 2022
* feat: add captures count list to grower details

* feat: finish the frontend for captures count in grower detail dialog

* feat: display the count of for each capture status in grower detail

* fix: call api to get related captures for each grower for counting status

* fix: get captures async for each grower

* fix: filter captures test

* fix: change the query to get captures count for each verification status
Ny-Rianala pushed a commit to Ny-Rianala/treetracker-admin-client that referenced this pull request Feb 10, 2022
* feat: add captures count list to grower details

* feat: finish the frontend for captures count in grower detail dialog

* feat: display the count of for each capture status in grower detail

* fix: call api to get related captures for each grower for counting status

* fix: get captures async for each grower

* fix: filter captures test

* fix: change the query to get captures count for each verification status
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grower Detail: Show number of captures
2 participants