Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sort Verify tool Species filter alphabetically #211

Merged
merged 3 commits into from
Nov 29, 2021

Conversation

bstetzer32
Copy link
Contributor

Description

Updated getSpecies query to sort the list of Species by name alphabetically for display on Verify tool.

Issue(s) addressed

What kind of change(s) does this PR introduce?

  • Enhancement
  • Bug fix
  • Refactor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features) - not applicable
  • Docs have been added / updated (for bug fixes / features) - not applicable

Issue

What is the current behavior?
The list of Species for the Verify tool filter appears to load in random order.

What is the new behavior?
The list of Species for the Verify tool filter loads in alphabetical order.

Breaking change

Does this PR introduce a breaking change?
No breaking changes.

Other useful information

@bstetzer32 bstetzer32 requested a review from a team as a code owner November 25, 2021 02:14
Copy link
Collaborator

@nmcharlton nmcharlton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one suggestion for a simpler implementation.

src/api/treeTrackerApi.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@nmcharlton nmcharlton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bstetzer32!

@nmcharlton nmcharlton merged commit 59d4ef3 into Greenstand:master Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List species in alphabetical order
2 participants