feat(earnings): Implement earnings tabular list UI #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oweedgar/treetracker-admin-client into feature/display_earnings_list_ui_only
nmcharlton
reviewed
Nov 13, 2021
There was a problem hiding this comment.
I'm a little concerned by how specific the styling is to individual elements, but I appreciate that the UI design is different from existing tools.
Maybe we extract common elements from this tool once we start implementing the other tools based on the same design.
…oweedgar/treetracker-admin-client into feature/display_earnings_list_ui_only
nmcharlton
approved these changes
Dec 1, 2021
…min-client into feature/display_earnings_list_ui_only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Developed UI for listing earnings, currently dummy earnings are listed from mock API as we wait for the earnings API to return more well-structured data.
Please check if the PR fulfills these requirements
Issue
What is the current behavior?
There was no earnings UI before
What is the new behavior?
Earnings tabular list UI with filters has been implemented
Other useful information
Only earnings table UI filled with dummy data is displayed, another PR will be done to address the integration of earnings list UI with earnings API.
ref #179