Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(species context): remove species count queries #169

Merged

Conversation

Mloweedgar
Copy link
Contributor

No description provided.

return species;
}),
);
// const speciesListWithCount = await Promise.all(
Copy link
Contributor Author

@Mloweedgar Mloweedgar Oct 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nmcharlton I have seen that this function makes many http request to get species counts, but the species object already carries the count information, I see no need for these requests. I would like to get your thoughts on this approach...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. The change you describe was made to the API in support of #115, so the speciesListWithCount bits can be removed.

@Mloweedgar Mloweedgar changed the title fix(species context): reduce species count queries fix(species context): remove species count queries Oct 8, 2021
@Mloweedgar Mloweedgar marked this pull request as ready for review October 8, 2021 19:45
@nmcharlton nmcharlton merged commit 993d566 into Greenstand:master Oct 11, 2021
@nmcharlton
Copy link
Collaborator

Thanks @Mloweedgar!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants