feat(planter filter): include partial matches in results #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mloweedgar
requested review from
gwynndp,
luacmartins and
nmcharlton
as code owners
nmcharlton
approved these changes
Sep 24, 2021
This was
linked to
issues
Sep 24, 2021
Mloweedgar
deleted the
feature/include_planter_filter_partial_matches
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extending filter to work with parts of the string when filtering planters by first name, last name, email or phone number. the filter has been made case insensitive and can find anything within a supplied string (eg. LIKE '%gmail.co%' )
in order to find planters easily
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Issue
What is the current behavior?
When filtering string fields in the Planters filter (First Name, Last Name, Email, Phone Number) only exact matches are returned in the results.
see #151 and #162 for more details
What is the new behavior?
When filtering string fields in the Planters filter (First Name, Last Name, Email, Phone Number) partial matches as well as exact matches are returned in the results. see image below
Breaking change
Does this PR introduce a breaking change?