Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buttons are the top of the patterns website #8

Closed
2 tasks
zanete opened this issue Oct 21, 2022 · 9 comments
Closed
2 tasks

Buttons are the top of the patterns website #8

zanete opened this issue Oct 21, 2022 · 9 comments
Assignees

Comments

@zanete
Copy link
Contributor

zanete commented Oct 21, 2022

Scope of work:

Image

@zanete
Copy link
Contributor Author

zanete commented Oct 21, 2022

Can I clarify what this means:
(1) There should be buttons at the top of the website for easier access to add new/edit existing?
(2) If you are not currently viewing a pattern, what would "edit" do? or would that only appear when viewing a pattern?

@holanita
Copy link

holanita commented Nov 1, 2022

@zanete I am aware that Osama is working on SOGS now. Do you have an ETA for this? This is added to the sprint [Oct-31]

@holanita
Copy link

holanita commented Nov 1, 2022

@zanete besides my previous note, can you help me add this to the patterns project board? I can't edit this.

@zanete
Copy link
Contributor Author

zanete commented Nov 1, 2022

@holanita It is planned for this week and all attempts will be made to do it, but SOGS is a priority, so if it takes more than anticipated, then there's a risk this could slip. Let me know how big of an issue that would be and I will keep an eye on the situation.
It should be one the patterns board. You should have permissions to edit this, can you not? is it that you don't see the board when trying to select? or you can't open the project selector at all?

@holanita holanita moved this to Todo in Patterns Nov 2, 2022
@holanita
Copy link

holanita commented Nov 2, 2022

@zanete I don't see any settings. this ticket is read-only for me. thanks for adding this to the patterns board, that is fine now.

I don't think it would be a major issue to skip this task. although the idea might come from @jawache (or from some of the team meetings I missed) so he should be aware. we have the same task in the training repo (to add a button permanently). these two things are the same and would be nice to have. the other one is higher priority than this one imo.

@zanete
Copy link
Contributor Author

zanete commented Nov 2, 2022

@holanita ok, given that, we can do a swap of this issue for Green-Software-Foundation/learn#108, will that be ok?
cc @osamajandali @jawache

@holanita
Copy link

holanita commented Nov 2, 2022

@zanete yes, pls try to make sure Green-Software-Foundation/learn#108 is completed for COP. thank you.

@osamajandali osamajandali moved this from Todo to In Progress in D: Web Nov 6, 2022
@osamajandali osamajandali moved this from In Progress to In Review in D: Web Nov 6, 2022
@zanete
Copy link
Contributor Author

zanete commented Nov 7, 2022

@holanita please review if you're happy with the update?

@holanita
Copy link

holanita commented Nov 7, 2022

@zanete seems to be working great
@osamajandali thanks!

@holanita holanita closed this as completed Nov 7, 2022
Repository owner moved this from Todo to Done in Patterns Nov 7, 2022
Repository owner moved this from In Review to Done in D: Web Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Status: Done
Development

No branches or pull requests

3 participants