Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Review & Testing] Comments during Code Freeze #85

Closed
holanita opened this issue Sep 29, 2022 · 5 comments
Closed

[Review & Testing] Comments during Code Freeze #85

holanita opened this issue Sep 29, 2022 · 5 comments
Assignees
@holanita
Labels
review
Milestone
31-Oct-22 Course ...

Comments

@holanita
Copy link
Contributor

@jawache @greenhsu123 @dubrie I'd suggest we announce code freeze once the pending issues and PRs are closed. can we use this issue to collect further comments and change request, if any? I'd like to focus on working with the LF on the setup in the upcoming weeks. we can do a final round of change requests later in one go if you all agree.
@holanita holanita self-assigned this Sep 29, 2022
@jawache
Copy link
Contributor

jawache commented Sep 30, 2022

Sounds great to me!

@holanita holanita mentioned this issue Sep 30, 2022
Closed
19 tasks
@jawache
Copy link
Contributor

jawache commented Oct 4, 2022

@dubrie we'll hold off merges for now but people can still propose.

After @greenhsu123 merges the two pending PRs we will change the settings on this repo to not allow merging.

@holanita holanita added this to the 31-Oct-22 Course Creation milestone Oct 6, 2022
@holanita holanita mentioned this issue Oct 10, 2022
Closed
14 tasks
@holanita
Copy link
Contributor Author

holanita commented Oct 24, 2022 •
edited
Loading

LF suggested some changes during the setup of the online course. See in this PR: #99.
Further minor issues and PRs added today. E.g. #104 and #107

@holanita holanita mentioned this issue Oct 24, 2022
Closed
@holanita
Copy link
Contributor Author

assigned Sarah as reviewer to all 3 open PRs

@holanita
Copy link
Contributor Author

holanita commented Nov 1, 2022

processed on Friday, no more open prs left. closing this as the course is finalized and will go live today.

@holanita holanita closed this as completed Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@holanita holanita

Labels
review
Projects
None yet
Milestone
31-Oct-22 Course Setup & Testing
Development

No branches or pull requests
2 participants
@jawache @holanita