New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Case study models #141

Merged

narekhovhannisyan merged 70 commits into dev from case-study-models

Sep 15, 2023

Contributor

gnanakeethan commented Sep 13, 2023 •

edited

Loading

Types of changes

Enhancement (project structure, spelling, grammar, formatting)
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have added tests to cover my changes.
All new and existing tests passed.

A description of the changes proposed in the Pull Request

Implements Models for PR

gnanakeethan marked this pull request as ready for review

September 13, 2023 10:11

gnanakeethan requested review from narekhovhannisyan, jawache and jmcook1186

September 13, 2023 10:11

gnanakeethan self-assigned this

jmcook1186 approved these changes

View reviewed changes

Contributor

jmcook1186 left a comment

lgtm
only thing to flag here is that in this current state sci-e is a hard requirement in every pipeline, because sci expects to find energy, and only sci-e adds energy to the impacts. Other models return e-cpu e-net or e-mem. Not blocking, but something to return to later.

narekhovhannisyan reviewed

View reviewed changes

src/lib/case-studies/aveva-model.ts Outdated Show resolved Hide resolved

narekhovhannisyan reviewed

View reviewed changes

src/lib/case-studies/aveva-model.ts Outdated Show resolved Hide resolved

narekhovhannisyan reviewed

View reviewed changes

src/lib/case-studies/aveva-model.ts Outdated Show resolved Hide resolved

narekhovhannisyan reviewed

View reviewed changes

src/lib/case-studies/aveva.test.ts Outdated Show resolved Hide resolved

narekhovhannisyan reviewed

View reviewed changes

src/lib/case-studies/emem-model.ts Outdated Show resolved Hide resolved

narekhovhannisyan reviewed

View reviewed changes

src/lib/case-studies/emem-model.ts Outdated Show resolved Hide resolved

narekhovhannisyan reviewed

View reviewed changes

src/lib/case-studies/emem-model.ts Outdated Show resolved Hide resolved

narekhovhannisyan reviewed

View reviewed changes

src/util/models-universe.ts Outdated Show resolved Hide resolved

gnanakeethan force-pushed the case-study-models branch from a998925 to 64f5480 Compare

September 13, 2023 14:15

narekhovhannisyan reviewed

View reviewed changes

src/util/models-universe.ts Outdated Show resolved Hide resolved

gnanakeethan requested review from narekhovhannisyan and jmcook1186

September 14, 2023 02:37

gnanakeethan and others added 12 commits

September 15, 2023 16:38


          Adding e-shoppen models

881a3e6

Signed-off-by: Gnanakeethan Balasubramaniam <[email protected]>


          Fix tests

Signed-off-by: Gnanakeethan Balasubramaniam <[email protected]>


          initial commit for e-mem model

7751b01


          return e-mem instead of energy

df794d2


          change out name energy -> e-mem

952eb96


          changing according to standards

720e100

Signed-off-by: Gnanakeethan Balasubramaniam <[email protected]>


          adding sci-accenture model

1eae7e9

Signed-off-by: Gnanakeethan Balasubramaniam <[email protected]>


          adds e-net model

294acbf


          fix comments

41377ce


          initial commit for e-mem model

abf4af6


          return e-mem instead of energy

86fa846


          change out name energy -> e-mem

44b1b3b

jmcook1186 added 5 commits

September 15, 2023 16:38


          yarn fix

69874f5


          adjust expedcted value in test

3414bac

Signed-off-by: jmc <[email protected]>


          add accenture model

d12ab50

Signed-off-by: jmc <[email protected]>


          fix linter

a57431b

Signed-off-by: jmc <[email protected]>


          fix unit test

e6f2574

Signed-off-by: jmc <[email protected]>

gnanakeethan force-pushed the case-study-models branch from d89d2c2 to e6f2574 Compare

September 15, 2023 11:09

gnanakeethan and others added 21 commits

September 15, 2023 16:52


          Fixing e-cpu field on the BoaviztaCpuImpactModel

1734d6d

Signed-off-by: Gnanakeethan Balasubramaniam <[email protected]>


          .eslintignore: add src d.ts, js files.

e342087


          ccf: apply linter to jsons.

f32734b


          config: init model ids.

64eb208


          lib: re-export all models from index.

e02f965


          lib: restructure boavizta imports, id.

a33444d


          lib: restucture case studies.

7f0b0ff


          lib: restucture ccf.

b6a9713


          types: extract kay value, interpolation to common.

1b6deaf


          lib: restructure import and comments for sci.

acccf8a


          lib: restructure teads, imports, and comments.

dd9b29f


          lib: restructure shell imp, imports, and comments.

afa7c93


          tests: fix interpolation import.

dd2e0f1


          lib: restructure watt-time, imports, and comments.

51c6d11


          Merge pull request #153 from Green-Software-Foundation/beautify-code

77d6763

Beautify code


          lint boavizta model

fb89310

Signed-off-by: jmc <[email protected]>


          fix boavizta test

1472d61

Signed-off-by: jmc <[email protected]>


          lint boavizta test

3787cc1

Signed-off-by: jmc <[email protected]>


          Test fixes for boavizta

011d153

Signed-off-by: Gnanakeethan Balasubramaniam <[email protected]>


          util: update imports from model universe.

8ca7e5b


          util: add teads, eshoppen models to universe.

d56399e

narekhovhannisyan approved these changes

View reviewed changes

narekhovhannisyan merged commit 4923dd2 into dev

narekhovhannisyan deleted the case-study-models branch

September 15, 2023 14:11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet